Re: [PATCH 2/2] comedi/ni_pcidio: make all defines uppercase

2018-12-17 Thread Alexander Schroth
We agree that preserving the reverse-engineered knowledge is more important than reducing code size. In turn, we have modified the patch to keep these defines and converted them to uppercase as well. Also, we agree that further abbreviating would be a bad idea.

Re: [PATCH 2/2] comedi/ni_pcidio: make all defines uppercase

2018-12-11 Thread Spencer Olson
On Tue, Dec 11, 2018 at 3:50 AM Alexander Schroth wrote: > > According to the Linux coding guidelines, defines should be written > in uppercase. This patch converts all define-statements in the > ni_pcidio.c file to uppercase, thus matching the coding style of the > kernel. > > Signed-off-by: Alex

[PATCH 2/2] comedi/ni_pcidio: make all defines uppercase

2018-12-11 Thread Alexander Schroth
According to the Linux coding guidelines, defines should be written in uppercase. This patch converts all define-statements in the ni_pcidio.c file to uppercase, thus matching the coding style of the kernel. Signed-off-by: Alexander Schroth Signed-off-by: Marco Ammon --- drivers/staging/comedi/