Re: [PATCH 2/2] media: staging: atomisp: Removed else branch in function

2020-10-06 Thread Joe Perches
On Tue, 2020-10-06 at 21:04 +0300, Dan Carpenter wrote: > Code should generally do "error handling" instead of "success handling". Maybe something to add to coding-style (in '6} Functions' maybe?)... > That way the success path is always indented one tab and the error path > is indented two tabs.

Re: [PATCH 2/2] media: staging: atomisp: Removed else branch in function

2020-10-06 Thread Dan Carpenter
On Tue, Oct 06, 2020 at 10:17:21AM +0200, Leonid Kushnir wrote: > This patch fixes the checkpatch.pl warning : > > WARNING: else is not generally useful after a break or return > > Expressions under 'else' branch in function 'gc0310_s_power' are > executed whenever the exppression in 'if' is Fals

[PATCH 2/2] media: staging: atomisp: Removed else branch in function

2020-10-06 Thread Leonid Kushnir
This patch fixes the checkpatch.pl warning : WARNING: else is not generally useful after a break or return Expressions under 'else' branch in function 'gc0310_s_power' are executed whenever the exppression in 'if' is False. Otherwise, return from function occurs. Therefore, there is no need in 'e