[PATCH 2/2] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-10 Thread Masood Mehmood
sparse reported dgap_do_fep_load is redeclared with different type. while fixing, I noticed __user attribute is used incorrectly in declaration. There is no need to define __user for firware-data. Replaced the __user with 'const uchar *' from function dgap_do_fep_load and did the same for

Re: [PATCH 2/2] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-10 Thread Greg KH
On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote: sparse reported dgap_do_fep_load is redeclared with different type. while fixing, I noticed __user attribute is used incorrectly in declaration. There is no need to define __user for firware-data. Replaced the __user with 'const

Re: [PATCH 2/2] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-10 Thread Masood Mehmood
On Mon, Mar 10, 2014 at 11:37:12AM -0700, Greg KH wrote: On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote: 1 file changed, 6 insertions(+), 7 deletions(-) I don't see a patch 1/2 here, did you forget to send it to me? Patch 1/2 has some unrelated changes. My bad, I forgot to

Re: [PATCH 2/2] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-10 Thread Greg KH
On Sun, Mar 09, 2014 at 12:33:32AM -0800, Masood Mehmood wrote: On Mon, Mar 10, 2014 at 11:37:12AM -0700, Greg KH wrote: On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote: 1 file changed, 6 insertions(+), 7 deletions(-) I don't see a patch 1/2 here, did you forget to send

Re: [PATCH 2/2] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-10 Thread Masood Mehmood
On Mon, Mar 10, 2014 at 12:34:22PM -0700, Greg KH wrote: On Sun, Mar 09, 2014 at 12:33:32AM -0800, Masood Mehmood wrote: On Mon, Mar 10, 2014 at 11:37:12AM -0700, Greg KH wrote: On Sat, Mar 08, 2014 at 11:18:42PM -0800, Masood Mehmood wrote: 1 file changed, 6 insertions(+), 7