Re: [PATCH 2/2] staging: rlt8192u: conditional compilation in r8192U_core.c

2014-08-01 Thread Greg KH
On Tue, Jun 24, 2014 at 02:46:55PM +0200, Antoine Schweitzer-Chaput wrote: function dump_eprom is only used when DEBUG_EPROM is set. function txqueue2outpipe is only used when USE_ONE_PIPE is unset. function GetRxPacketShiftBytes819xUsb is only used when USB_RX_AGGREGATION_SUPPORT is set.

Re: [PATCH 2/2] staging: rlt8192u: conditional compilation in r8192U_core.c

2014-08-01 Thread Antoine Schweitzer-Chaput
On Fri, Aug 01, 2014 at 12:59:43AM -0700, Greg KH wrote: /* this is only for debug */ +#ifdef DEBUG_EPROM how can this ever be set? If no one sets it, just remove the code entirely please. I guess it's supposed to be set manually in the code (there's a large list around l.60).

[PATCH 2/2] staging: rlt8192u: conditional compilation in r8192U_core.c

2014-07-31 Thread Antoine Schweitzer-Chaput
function dump_eprom is only used when DEBUG_EPROM is set. function txqueue2outpipe is only used when USE_ONE_PIPE is unset. function GetRxPacketShiftBytes819xUsb is only used when USB_RX_AGGREGATION_SUPPORT is set. Compile these functions only when they will actually be used. Signed-off-by: