subject:"\[PATCH 2\/3\]\[staging\-next\] staging\: pi433\: Make functions rf69_set_bandwidth_intern static"

Re: [PATCH 2/3][staging-next] staging: pi433: Make functions rf69_set_bandwidth_intern static

2017-07-20 Thread Wolf Entwicklungen

Reviewed-by: Marcus Wolf Am Di, 18.07.2017, 15:03 schrieb Colin King: > From: Colin Ian King > > The function rf69_set_bandwidth_intern is local to the source > and do not need to be in global scope, so make it static. Also > break overly

Re: [PATCH 2/3][staging-next] staging: pi433: Make functions rf69_set_bandwidth_intern static

2017-07-19 Thread Marcus Wolf

Hi Colin, thanks for your patches. #1 is fine. Same fix was provided by Joseph Wright. I tested it and it works fine. #2 looks fine, too. Conerning #3, I would suggest to declare rf69_set_dc_cut_off_frequency static, as well. Would you prefer to remove rf69_set_dc_cut_off_frequency from the

[PATCH 2/3][staging-next] staging: pi433: Make functions rf69_set_bandwidth_intern static

2017-07-18 Thread Colin King

From: Colin Ian King The function rf69_set_bandwidth_intern is local to the source and do not need to be in global scope, so make it static. Also break overly wide line. Cleans up sparse warning: symbol 'update_share_count' was not declared. Should it be static?