Re: [PATCH 2/3] binder: do not initialize locals passed to copy_from_user()

2020-02-26 Thread Kees Cook
On Wed, Feb 26, 2020 at 03:58:41PM +0100, Alexander Potapenko wrote: > On Tue, Feb 25, 2020 at 4:24 PM Alexander Potapenko wrote: > > > > On Tue, Feb 25, 2020 at 5:18 AM Kees Cook wrote: > > > > > > On Mon, Feb 24, 2020 at 04:35:00PM +0100, gli...@google.com wrote: > > > > Certain copy_from_user(

Re: [PATCH 2/3] binder: do not initialize locals passed to copy_from_user()

2020-02-24 Thread Kees Cook
On Mon, Feb 24, 2020 at 04:35:00PM +0100, gli...@google.com wrote: > Certain copy_from_user() invocations in binder.c are known to > unconditionally initialize locals before their first use, like e.g. in > the following case: > > struct binder_transaction_data tr; > if (copy_from_user(