Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct

2016-03-22 6:05 GMT+09:00 Greg KH : > On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote: >> For using tty_alloc_driver, SerialDriver has to be pointer type. > > Yes, but you aren't calling tty_alloc_driver, so this patch totally > breaks the working code :(

Re: [PATCH 2/3] staging: dgnc: use pointer type of tty_struct

On Mon, Mar 14, 2016 at 01:28:31PM +0900, Daeseok Youn wrote: > For using tty_alloc_driver, SerialDriver has to be pointer type. Yes, but you aren't calling tty_alloc_driver, so this patch totally breaks the working code :( Please be more careful... greg k-h

[PATCH 2/3] staging: dgnc: use pointer type of tty_struct

For using tty_alloc_driver, SerialDriver has to be pointer type. It also has checkpatch.pl warning about Camelcase, so SerialDriver is changed to serial_driver. Signed-off-by: Daeseok Youn --- drivers/staging/dgnc/dgnc_driver.h | 4 +- drivers/staging/dgnc/dgnc_tty.c