RE: [PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

2014-04-10 Thread David Laight
From: Dan Carpenter ... - if (auth_alg == 2) { + if (auth_alg == dot11AuthAlgrthm_8021X) { + /* get ether_type */ + ptr = ptr + pfhdr-attrib.hdrlen + LLC_HEADER_SIZE; + memcpy(ether_type, ptr, 2); + ether_type = ntohs((unsigned

[PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

2014-04-09 Thread Larry Finger
Zero-initializing ether_type masked that the ether type would never be obtained for 8021x packets and the comparition against eapol_type would always fail. Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org ---

Re: [PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

2014-04-09 Thread Sergei Shtylyov
On 04/09/2014 08:12 PM, Larry Finger wrote: Zero-initializing ether_type masked that the ether type would never be obtained for 8021x packets and the comparition against eapol_type would always fail. Reported-by: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Larry Finger