Re: [PATCH 2/3] staging: unisys: use error codes

2015-03-27 Thread Sudip Mukherjee
On Fri, Mar 27, 2015 at 09:47:16AM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 27, 2015 at 02:00:58PM +0530, Sudip Mukherjee wrote: > > } > > rc = cdev_add(&file_cdev, MKDEV(MAJOR(major_dev), 0), 1); > > if (rc < 0) { > > unregister_chrdev_region(major_dev, 1); > > -

Re: [PATCH 2/3] staging: unisys: use error codes

2015-03-27 Thread Greg Kroah-Hartman
On Fri, Mar 27, 2015 at 02:00:58PM +0530, Sudip Mukherjee wrote: > we were just returning -1 to the calling function which was again > returning that if the module failed to load. Now we are returning the > actual error codes. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/unisys/vis

[PATCH 2/3] staging: unisys: use error codes

2015-03-27 Thread Sudip Mukherjee
we were just returning -1 to the calling function which was again returning that if the module failed to load. Now we are returning the actual error codes. Signed-off-by: Sudip Mukherjee --- drivers/staging/unisys/visorchipset/file.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletion