Re: [PATCH 2/9] VC04_SERVICES: Add top level compat ioctl handler

2017-01-19 Thread Michael Zoran
On Thu, 2017-01-19 at 11:00 +0300, Dan Carpenter wrote: > On Wed, Jan 18, 2017 at 11:37:55PM -0800, Michael Zoran wrote: > > This whole driver is a chicken and egg problem.  The existing code > > is > > so hard to read and maintain, that it's hard to improve it in a > > incremental way.   Yet,

Re: [PATCH 2/9] VC04_SERVICES: Add top level compat ioctl handler

2017-01-19 Thread Dan Carpenter
On Wed, Jan 18, 2017 at 11:37:55PM -0800, Michael Zoran wrote: > This whole driver is a chicken and egg problem. The existing code is > so hard to read and maintain, that it's hard to improve it in a > incremental way. Yet, trowing large sections out the door is too hard > to get seriously

Re: [PATCH 2/9] VC04_SERVICES: Add top level compat ioctl handler

2017-01-18 Thread Michael Zoran
On Thu, 2017-01-19 at 02:01 +0300, Dan Carpenter wrote: > On Wed, Jan 18, 2017 at 07:04:46AM -0800, Michael Zoran wrote: > > Add the top level compat ioctl handler as a placeholder > > for adding additional handlers. > > > > The ioctls are first filtered and forwarded to the > > regular ioctl

Re: [PATCH 2/9] VC04_SERVICES: Add top level compat ioctl handler

2017-01-18 Thread Dan Carpenter
On Wed, Jan 18, 2017 at 07:04:46AM -0800, Michael Zoran wrote: > Add the top level compat ioctl handler as a placeholder > for adding additional handlers. > > The ioctls are first filtered and forwarded to the > regular ioctl handler if the ioctl does not require > any extra compatibility

[PATCH 2/9] VC04_SERVICES: Add top level compat ioctl handler

2017-01-18 Thread Michael Zoran
Add the top level compat ioctl handler as a placeholder for adding additional handlers. The ioctls are first filtered and forwarded to the regular ioctl handler if the ioctl does not require any extra compatibility processing. Signed-off-by: Michael Zoran ---