On Tue, Dec 15, 2015 at 05:10:39PM +, Simmons, James A. wrote:
>I have been pondering if pushing bug fixes before style cleanups
> is the right thing to do.
Generally push the least controversial patches first so that if you
have to redo one patch, then the rest are already applied and don't n
>Actually we're going to have to redo so much code that it's not worth it
>for me to review the rest of these patches.
Sorry I didn't get back to you sooner but I was on vacation. Thanks for
reviewing this work. Especially since this is the first major bug fixing merge
for the lustre client wh
On Wed, Dec 02, 2015 at 04:20:59PM +0300, Alexander Zarochentsev wrote:
> > BAD: if (rc != 0)
> > GOOD: if (rc)
>
> The latest suggestion is not correct,
> from http://wiki.lustre.org/Lustre_Coding_Guidelines :
> Conditional boolean (if (expr)), scalar (if (val != 0)) and pointer
> (if (ptr !
Hello,
On Wed, Dec 2, 2015 at 3:59 PM, Dan Carpenter wrote:
> Actually we're going to have to redo so much code that it's not worth it
> for me to review the rest of these patches. Please just look over
> everything again:
>
> BAD: return -1;
> GOOD: return -EINVAL;
>
> BAD: failed0:
> GO
Actually we're going to have to redo so much code that it's not worth it
for me to review the rest of these patches. Please just look over
everything again:
BAD: return -1;
GOOD: return -EINVAL;
BAD: failed0:
GOOD: free_something:
BAD: if (rc != 0)
GOOD: if (rc)
Do one thing per p
From: Amir Shehata
This patch addresses a set of related issues: LU-5734, LU-5839,
LU-5849, LU-5850.
Create the local lnet_startup_lndni() API. This function starts
up one LND. lnet_startup_lndnis() calls this function in a loop
on every ni in the list passed in. lnet_startup_lndni() is
respo
