Re: [PATCH 26/31] staging/comedi/das16: Make timer initialization unconditional

2017-09-01 Thread Kees Cook
On Fri, Sep 1, 2017 at 2:38 AM, Ian Abbott wrote: > On 01/09/17 10:29, Ian Abbott wrote: >> >> On 01/09/17 00:29, Kees Cook wrote: >>> >>> With timer initialization made unconditional, there is no reason to >>> make del_timer_sync() calls conditionally, there by removing the

Re: [PATCH 26/31] staging/comedi/das16: Make timer initialization unconditional

2017-09-01 Thread Ian Abbott
On 01/09/17 10:29, Ian Abbott wrote: On 01/09/17 00:29, Kees Cook wrote: With timer initialization made unconditional, there is no reason to make del_timer_sync() calls conditionally, there by removing the test of the .data field. Cc: Ian Abbott Cc: H Hartley Sweeten

Re: [PATCH 26/31] staging/comedi/das16: Make timer initialization unconditional

2017-09-01 Thread Ian Abbott
On 01/09/17 00:29, Kees Cook wrote: With timer initialization made unconditional, there is no reason to make del_timer_sync() calls conditionally, there by removing the test of the .data field. Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Greg

Re: [PATCH 26/31] staging/comedi/das16: Make timer initialization unconditional

2017-08-31 Thread Greg Kroah-Hartman
On Thu, Aug 31, 2017 at 04:29:38PM -0700, Kees Cook wrote: > With timer initialization made unconditional, there is no reason to > make del_timer_sync() calls conditionally, there by removing the test > of the .data field. > > Cc: Ian Abbott > Cc: H Hartley Sweeten

[PATCH 26/31] staging/comedi/das16: Make timer initialization unconditional

2017-08-31 Thread Kees Cook
With timer initialization made unconditional, there is no reason to make del_timer_sync() calls conditionally, there by removing the test of the .data field. Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Greg Kroah-Hartman