On Tue, Jul 03, 2018 at 09:10:55AM +0100, Justin Skists wrote:
> > @@ -787,7 +787,7 @@ static ssize_t message_store_helper(const char *buf,
> > size_t count,
> > continue;
> > }
> >
> > - index = simple_strtoul(cp, , 10);
> > + index =
On Wed, Jul 04, 2018 at 10:46:05PM +0300, Tamir Suliman wrote:
>
> Interesting construct... Yeah I'm little bit rusty on my C /programming .
> I understand proper coding style may be should end with else so I wasn't
> sure .. however this resolved the warnings. :)
The code you wrote was
Interesting construct... Yeah I'm little bit rusty on my C
/programming . I understand proper coding style may be should end with
else so I wasn't sure .. however this resolved the warnings. :)
Did you compile this?
Yes I did compile however the only issue i found when I'm compiling
> On 03 July 2018 at 08:31 Tamir Suliman wrote:
> +++ b/drivers/staging/speakup/keyhelp.c
> @@ -167,7 +167,7 @@ int spk_handle_help(struct vc_data *vc, u_char type,
> u_char ch, u_short key)
> synth_printf("%s\n", spk_msg_get(MSG_HELP_INFO));
> build_key_data(); /*
On Tue, Jul 03, 2018 at 07:31:20AM +, Tamir Suliman wrote:
> Fixed the following style/coding issues:
> *updated ---help to the prefered new help texts which reduces the code/file
> size and fixes the warning messages
> *Used else if instead of elese as else is not generally useful after a
Fixed the following style/coding issues:
*updated ---help to the prefered new help texts which reduces the code/file
size and fixes the warning messages
*Used else if instead of elese as else is not generally useful after a break or
return, not sure if this is the acceptable but it resolved the
