[PATCH 3/3] staging: dgap: introduce dgap_stop()

2014-10-08 Thread Daeseok Youn
The dgap_init_module() need to unwind for cleanup variables properly. Because dgap_init_module() calls dgap_cleanup_module() for freeing variables but this function is possible to free variables which are not allocated. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com ---

Re: [PATCH 3/3] staging: dgap: introduce dgap_stop()

2014-10-08 Thread Dan Carpenter
All three of these patches are good and a nice improvement. This one is a good bugfix. I have some notes for later, though below. On Wed, Oct 08, 2014 at 08:13:56PM +0900, Daeseok Youn wrote: diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 7c79fe6..00f34b5 100644

Re: [PATCH 3/3] staging: dgap: introduce dgap_stop()

2014-10-08 Thread DaeSeok Youn
Hi, Dan 2014-10-08 20:37 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: All three of these patches are good and a nice improvement. This one is a good bugfix. I have some notes for later, though below. On Wed, Oct 08, 2014 at 08:13:56PM +0900, Daeseok Youn wrote: diff --git