Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-12 Thread Greg KH
On Mon, Aug 12, 2013 at 06:18:00PM +, Paul Zimmerman wrote: > > From: popcornmix [mailto:popcorn...@gmail.com] > > Sent: Monday, August 12, 2013 6:39 AM > > > > On Mon, Aug 12, 2013 at 8:40 AM, Matthijs Kooijman > > wrote: > > > > > Paul, did you try the patch without this hunk? > > > Dom,

RE: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-12 Thread Paul Zimmerman
> From: popcornmix [mailto:popcorn...@gmail.com] > Sent: Monday, August 12, 2013 6:39 AM > > On Mon, Aug 12, 2013 at 8:40 AM, Matthijs Kooijman wrote: > > > Paul, did you try the patch without this hunk? > > Dom, can you tell use why this hunk is needed? > > The microframe patch originally came

Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-12 Thread Dan Carpenter
On Sun, Aug 11, 2013 at 12:50:19PM -0700, Paul Zimmerman wrote: > +static int dwc2_find_single_uframe(struct dwc2_hsotg *hsotg, struct dwc2_qh > *qh) > +{ > + unsigned short utime = qh->usecs; > + int done = 0; > + int i = 0; > + int ret = -1; > + > + while (!done) { I don't c

Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-12 Thread Matthijs Kooijman
Hi Paul & Dom, I haven't got time to look closely right now, but at first glance most of my comments have been resolved. One thing that is still in there, is this piece of code for which I'm not sure if it is really related to the topic of the patch: > @@ -780,6 +784,10 @@ static void dwc2_assig

[PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-11 Thread Paul Zimmerman
From: Dom Cobley The transfer scheduler in the dwc2 driver is pretty basic, not to mention buggy. It works fairly well with just a couple of devices plugged in, but if you add, say, multiple devices with periodic endpoints, the scheduler breaks down and can't enumerate all the devices. To improv