If true_count is not same with brd->nasync, warning messages are
printed. But it has duplicated messages within if statement.

Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com>
---
 drivers/staging/dgap/dgap.c |   17 ++++++-----------
 1 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index b1253c0..51f9ebc 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -1374,19 +1374,14 @@ static int dgap_tty_init(struct board_t *brd)
                brd->nasync = brd->maxports;
 
        if (true_count != brd->nasync) {
-               if ((brd->type == PPCM) && (true_count == 64)) {
-                       pr_warn("dgap: %s configured for %d ports, has %d 
ports.\n",
-                               brd->name, brd->nasync, true_count);
-                       pr_warn("dgap: Please make SURE the EBI cable running 
from the card\n");
-                       pr_warn("dgap: to each EM module is plugged into EBI 
IN!\n");
-               } else if ((brd->type == PPCM) && (true_count == 0)) {
-                       pr_warn("dgap: %s configured for %d ports, has %d 
ports.\n",
-                               brd->name, brd->nasync, true_count);
+               pr_warn("dgap: %s configured for %d ports, has %d ports.\n",
+                       brd->name, brd->nasync, true_count);
+
+               if ((brd->type == PPCM) &&
+                   (true_count == 64 || true_count == 0)) {
                        pr_warn("dgap: Please make SURE the EBI cable running 
from the card\n");
                        pr_warn("dgap: to each EM module is plugged into EBI 
IN!\n");
-               } else
-                       pr_warn("dgap: %s configured for %d ports, has %d 
ports.\n",
-                               brd->name, brd->nasync, true_count);
+               }
 
                brd->nasync = true_count;
 
-- 
1.7.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to