Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

2017-03-20 Thread Arnd Bergmann
On Mon, Mar 20, 2017 at 4:05 PM, Stephen Hemminger wrote: > On Mon, 20 Mar 2017 10:32:19 +0100 > Arnd Bergmann wrote: > >> -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/) >> +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void) >> { > Why keep the comment? The comment

Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

2017-03-20 Thread Stephen Hemminger
On Mon, 20 Mar 2017 10:32:19 +0100 Arnd Bergmann wrote: > -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/) > +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void) > { Why keep the comment? ___ devel mailing list de...@linuxdri

[PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

2017-03-20 Thread Arnd Bergmann
ia_css_dequeue_param_buffers does not have an arguement type, causing a warning: drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c: In function 'ia_css_dequeue_param_buffers': drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:3728:6: error: old-style function de