3.16.63-rc1 review patch. If anyone has any objections, please let me know.
------------------ From: Michael Kelley <mikel...@microsoft.com> commit 35b69a420bfb56b7b74cb635ea903db05e357bec upstream. Add support for platforms where pit_shutdown() doesn't work because of a quirk in the PIT emulation. On these platforms setting the counter register to zero causes the PIT to start running again, negating the shutdown. Provide a global variable that controls whether the counter register is zero'ed, which platform specific code can override. Signed-off-by: Michael Kelley <mikel...@microsoft.com> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: "gre...@linuxfoundation.org" <gre...@linuxfoundation.org> Cc: "de...@linuxdriverproject.org" <de...@linuxdriverproject.org> Cc: "daniel.lezc...@linaro.org" <daniel.lezc...@linaro.org> Cc: "virtualizat...@lists.linux-foundation.org" <virtualizat...@lists.linux-foundation.org> Cc: "jgr...@suse.com" <jgr...@suse.com> Cc: "akata...@vmware.com" <akata...@vmware.com> Cc: "o...@aepfle.de" <o...@aepfle.de> Cc: "a...@canonical.com" <a...@canonical.com> Cc: vkuznets <vkuzn...@redhat.com> Cc: "jasow...@redhat.com" <jasow...@redhat.com> Cc: "marcelo.ce...@canonical.com" <marcelo.ce...@canonical.com> Cc: KY Srinivasan <k...@microsoft.com> Link: https://lkml.kernel.org/r/1541303219-11142-2-git-send-email-mikel...@microsoft.com [bwh: Backported to 3.16: - Don't use __ro_after_init - Adjust context, indentation] Signed-off-by: Ben Hutchings <b...@decadent.org.uk> --- drivers/clocksource/i8253.c | 14 ++++++++++++-- include/linux/i8253.h | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) --- a/drivers/clocksource/i8253.c +++ b/drivers/clocksource/i8253.c @@ -19,6 +19,13 @@ DEFINE_RAW_SPINLOCK(i8253_lock); EXPORT_SYMBOL(i8253_lock); +/* + * Handle PIT quirk in pit_shutdown() where zeroing the counter register + * restarts the PIT, negating the shutdown. On platforms with the quirk, + * platform specific code can set this to false. + */ +bool i8253_clear_counter_on_shutdown = true; + #ifdef CONFIG_CLKSRC_I8253 /* * Since the PIT overflows every tick, its not very useful @@ -123,8 +130,11 @@ static void init_pit_timer(enum clock_ev if (evt->mode == CLOCK_EVT_MODE_PERIODIC || evt->mode == CLOCK_EVT_MODE_ONESHOT) { outb_p(0x30, PIT_MODE); - outb_p(0, PIT_CH0); - outb_p(0, PIT_CH0); + + if (i8253_clear_counter_on_shutdown) { + outb_p(0, PIT_CH0); + outb_p(0, PIT_CH0); + } } break; --- a/include/linux/i8253.h +++ b/include/linux/i8253.h @@ -21,6 +21,7 @@ #define PIT_LATCH ((PIT_TICK_RATE + HZ/2) / HZ) extern raw_spinlock_t i8253_lock; +extern bool i8253_clear_counter_on_shutdown; extern struct clock_event_device i8253_clockevent; extern void clockevent_i8253_init(bool oneshot); _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
