Re: [PATCH 4/6] staging: media: atomisp: fix build when PM is disabled

2017-03-20 Thread Jérémy Lefaure
On Thu, 16 Mar 2017 17:50:10 + Alan Cox wrote: > > + if (IS_ENABLED(CONFI_PM)) { > > I think not. > > Please actually test build both ways at the very least. > > Alan > I did test and it did compile both ways. I didn't think about checking the output of the compilation and I don't ha

Re: [PATCH 4/6] staging: media: atomisp: fix build when PM is disabled

2017-03-16 Thread Alan Cox
> + if (IS_ENABLED(CONFI_PM)) { I think not. Please actually test build both ways at the very least. Alan ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 4/6] staging: media: atomisp: fix build when PM is disabled

2017-03-15 Thread Greg Kroah-Hartman
On Wed, Mar 15, 2017 at 02:09:19PM -0400, Jérémy Lefaure wrote: > The function atomisp_restore_iumit_reg is unused when PM is disabled. > Adding __maybe_unused to the function definition avoids a warning. > > During a reset (atomisp_reset), PM functions atomisp_runtime_suspend, > atomisp_mrfld_pow

[PATCH 4/6] staging: media: atomisp: fix build when PM is disabled

2017-03-15 Thread Jérémy Lefaure
The function atomisp_restore_iumit_reg is unused when PM is disabled. Adding __maybe_unused to the function definition avoids a warning. During a reset (atomisp_reset), PM functions atomisp_runtime_suspend, atomisp_mrfld_power_down, atomisp_mrfld_power_up and atomisp_runtime_resume should be calle