Re: [PATCH 4/7] staging: mt7621-dma: Remove assignment in if

On Wed, Mar 21, 2018 at 09:21:55AM +1100, NeilBrown wrote: > I don't like this change. We now call vchan_find_desc() in situations > where we didn't before. It isn't a very expensive function so that > doesn't matter a lot, but I think it is best not to do this. > If you want to remove the

Re: [PATCH 4/7] staging: mt7621-dma: Remove assignment in if

On Tue, Mar 20 2018, Christian Lütke-Stetzkamp wrote: > Fixes checkpatch error: ASSIGN_IN_IF by defining a new variable before if > > Signed-off-by: Christian Lütke-Stetzkamp > --- > drivers/staging/mt7621-dma/ralink-gdma.c | 3 ++- > 1 file changed, 2 insertions(+), 1

[PATCH 4/7] staging: mt7621-dma: Remove assignment in if

Fixes checkpatch error: ASSIGN_IN_IF by defining a new variable before if Signed-off-by: Christian Lütke-Stetzkamp --- drivers/staging/mt7621-dma/ralink-gdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c