Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mark Brown
On Tue, Nov 17, 2020 at 09:38:30AM +0100, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > This also appears to be missing a DT binding document, binding > > documentation is required for anything with DT support. > The DT binding is documented on patch 3/8, together with MFD. > As

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mark Brown
On Tue, Nov 17, 2020 at 09:08:22AM +0100, Mauro Carvalho Chehab wrote: > Mark Brown escreveu: > > This probe code looks very different to other regulator drivers, this > > alone should have been a warning that the driver needs some substantial > > refactoring here. As indicated information

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mauro Carvalho Chehab
Em Mon, 16 Nov 2020 18:38:33 + Mark Brown escreveu: > On Mon, Nov 16, 2020 at 01:59:30PM +0100, Mauro Carvalho Chehab wrote: > > > This driver is ready for mainstream. Move it out of staging. > > There's quite a few issues here, to be honest I'm disappointed some of > them weren't caught

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-17 Thread Mauro Carvalho Chehab
Hi Mark, Em Mon, 16 Nov 2020 18:38:33 + Mark Brown escreveu: > > This driver is ready for mainstream. Move it out of staging. > > There's quite a few issues here, to be honest I'm disappointed some of > them weren't caught during staging review, this needs fairly substantial > work and

Re: [PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-16 Thread Mark Brown
On Mon, Nov 16, 2020 at 01:59:30PM +0100, Mauro Carvalho Chehab wrote: > This driver is ready for mainstream. Move it out of staging. There's quite a few issues here, to be honest I'm disappointed some of them weren't caught during staging review, this needs fairly substantial work and there's

[PATCH 4/8] regulator: hi6421v600-regulator: move it from staging

2020-11-16 Thread Mauro Carvalho Chehab
This driver is ready for mainstream. Move it out of staging. Signed-off-by: Mauro Carvalho Chehab --- MAINTAINERS | 7 +- drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile| 1 +