Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-11 Thread Nicholas Mc Guire
On Tue, Sep 11, 2018 at 10:20:41AM +0300, Dan Carpenter wrote: > On Tue, Sep 11, 2018 at 06:48:27AM +, Nicholas Mc Guire wrote: > > On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: > > > Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use > > > drm_dev_register.") repla

Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-11 Thread Dan Carpenter
On Tue, Sep 11, 2018 at 07:41:10AM +, Nicholas Mc Guire wrote: > On Tue, Sep 11, 2018 at 08:53:35AM +0200, Hans de Goede wrote: > > Hi, > > > > On 11-09-18 08:48, Nicholas Mc Guire wrote: > > >On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: > > >>Commit 1daddbc8dec5 ("staging: v

Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-11 Thread Nicholas Mc Guire
On Tue, Sep 11, 2018 at 08:53:35AM +0200, Hans de Goede wrote: > Hi, > > On 11-09-18 08:48, Nicholas Mc Guire wrote: > >On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: > >>Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use > >>drm_dev_register.") replaced the obsolere dr

Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-11 Thread Dan Carpenter
On Tue, Sep 11, 2018 at 06:48:27AM +, Nicholas Mc Guire wrote: > On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: > > Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use > > drm_dev_register.") replaced the obsolere drm_get_pci_dev() with > > normal pci probe and remove

Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-10 Thread Nicholas Mc Guire
On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: > Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use > drm_dev_register.") replaced the obsolere drm_get_pci_dev() with > normal pci probe and remove functions. > > But the new vbox_pci_probe() is missing a pci_enable_devic

Re: [PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-10 Thread Hans de Goede
Hi, On 11-09-18 08:48, Nicholas Mc Guire wrote: On Mon, Sep 10, 2018 at 08:30:38PM +0200, Hans de Goede wrote: Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use drm_dev_register.") replaced the obsolere drm_get_pci_dev() with normal pci probe and remove functions. But the new vbox

[PATCH 4.19 regression fix 1/2] staging: vboxvideo: Fix IRQs no longer working

2018-09-10 Thread Hans de Goede
Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use drm_dev_register.") replaced the obsolere drm_get_pci_dev() with normal pci probe and remove functions. But the new vbox_pci_probe() is missing a pci_enable_device() call, causing interrupts to not be delivered. This causes resizes of