Re: [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Greg KH
On Thu, Sep 23, 2021 at 10:18:14PM +0800, Cheng Chao wrote: > Fixes: commit e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up > cached buffer alloc") > the commit e7f63771b60e introduced the bug which didn't test page which maybe > NULL. > and previous logic was right. > > the e7f63771b6

[PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Cheng Chao
Fixes: commit e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc") the commit e7f63771b60e introduced the bug which didn't test page which maybe NULL. and previous logic was right. the e7f63771b60e has been merged in v4.8-rc3, only longterm 4.9.x has this bug, and othe

[PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Cheng Chao
Fixes: commit e7f63771b60e ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc") the commit e7f63771b60e introduced the bug which didn't test page which maybe NULL. and previous logic was right. the e7f63771b60e has been merged in v4.8-rc3, only longterm 4.9.x has this bug, and othe

Re: [PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-23 Thread Greg KH
On Wed, Sep 22, 2021 at 08:17:15PM +0800, Cheng Chao wrote: > I notice that v4.9.283 has released, but this patch is not merged. > It's exactly a bug. Can you please resend this and include all of the information in this thread in the changelog comment explaining why this is only needed for this o

Re: [PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-22 Thread Cheng Chao
I notice that v4.9.283 has released, but this patch is not merged. It's exactly a bug. On Sat, Sep 11, 2021 at 10:40 PM Cheng Chao wrote: > > the bug has been introduced by the patch: > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/staging/android/ion/ion_s

Re: [PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-11 Thread Cheng Chao
the bug has been introduced by the patch: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/staging/android/ion/ion_system_heap.c?h=v4.9.282&id=e7f63771b60e7802c5a9b437c5ab1a8e33a0bb35 On Sat, Sep 11, 2021 at 10:20 PM Cheng Chao wrote: > > for longterm v4.4.283,

Re: [PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-11 Thread Cheng Chao
for longterm v4.4.283, the code has checked if (!page) https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/staging/android/ion/ion_system_heap.c?h=v4.4.283 static struct page *alloc_buffer_page(struct ion_system_heap *heap, struct ion_buffer *buffer, unsign

Re: [PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-11 Thread Greg KH
On Sat, Sep 11, 2021 at 07:21:15PM +0800, Cheng Chao wrote: > kernel panic is here: > > Unable to handle kernel paging request at virtual address b038 > pgd = d9d94000 > [b038] *pgd= > Internal error: Oops: 2805 [#1] PREEMPT SMP ARM > ... > task: daa2dd00 task.stack: da194000 > PC

[PATCH] [PATCH 4.9] staging: android: ion: fix page is NULL

2021-09-11 Thread Cheng Chao
kernel panic is here: Unable to handle kernel paging request at virtual address b038 pgd = d9d94000 [b038] *pgd= Internal error: Oops: 2805 [#1] PREEMPT SMP ARM ... task: daa2dd00 task.stack: da194000 PC is at v7_dma_clean_range+0x1c/0x34 LR is at arm_dma_sync_single_for_device+0x4