On Tue, Sep 24, 2013 at 3:20 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Tue, Sep 24, 2013 at 02:40:10PM -0400, Lidza Louina wrote:
Instead of writing:
brd-SerialDriver = alloc_tty_driver(MAXPORTS);
if (!brd-SerialDriver){
goto free_stuff;
On Wed, Sep 25, 2013 at 01:22:08PM -0400, Lidza Louina wrote:
I looked at other uses of the function alloc_tty_driver() in
the kernel and none of them seem to follow up with a
call to kfree().
Read my first response again. I showed how to do this. Your setting
up a bunch of things in a
On Wed, Sep 25, 2013 at 2:34 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Wed, Sep 25, 2013 at 01:22:08PM -0400, Lidza Louina wrote:
I looked at other uses of the function alloc_tty_driver() in
the kernel and none of them seem to follow up with a
call to kfree().
Read my first
On Wed, Sep 25, 2013 at 06:13:47PM -0400, Lidza Louina wrote:
On Wed, Sep 25, 2013 at 2:34 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Wed, Sep 25, 2013 at 01:22:08PM -0400, Lidza Louina wrote:
I looked at other uses of the function alloc_tty_driver() in
the kernel and none of
On Wed, Sep 25, 2013 at 6:29 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Wed, Sep 25, 2013 at 06:13:47PM -0400, Lidza Louina wrote:
On Wed, Sep 25, 2013 at 2:34 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Wed, Sep 25, 2013 at 01:22:08PM -0400, Lidza Louina wrote:
I
On Mon, Sep 23, 2013 at 8:27 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Mon, Sep 23, 2013 at 06:47:16PM -0400, Lidza Louina wrote:
This patch removes these warnings:
potential null dereference 'brd-SerialDriver'. (alloc_tty_driver returns
null)
potential null dereference
On Tue, Sep 24, 2013 at 02:40:10PM -0400, Lidza Louina wrote:
Instead of writing:
brd-SerialDriver = alloc_tty_driver(MAXPORTS);
if (!brd-SerialDriver){
goto free_stuff;
return -ENOMEM;
}
Would it correct if I wrote:
This patch removes these warnings:
potential null dereference 'brd-SerialDriver'. (alloc_tty_driver returns null)
potential null dereference 'brd-PrintDriver'. (alloc_tty_driver returns null)
This warning popped up because there wasn't a check
to make sure that the serial and print drivers were
On Mon, Sep 23, 2013 at 06:47:16PM -0400, Lidza Louina wrote:
This patch removes these warnings:
potential null dereference 'brd-SerialDriver'. (alloc_tty_driver returns
null)
potential null dereference 'brd-PrintDriver'. (alloc_tty_driver returns null)
This warning popped up because there