Free memory allocated in wilc_add_rx_gtk() before returing from the
function.

Signed-off-by: Ajay Singh <ajay.kat...@microchip.com>
---
 drivers/staging/wilc1000/host_interface.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c 
b/drivers/staging/wilc1000/host_interface.c
index a8771d5..74095ec 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2881,8 +2881,10 @@ int wilc_add_rx_gtk(struct wilc_vif *vif, const u8 
*rx_gtk, u8 gtk_key_len,
        msg.body.key_info.attr.wpa.key = kmemdup(rx_gtk,
                                                 key_len,
                                                 GFP_KERNEL);
-       if (!msg.body.key_info.attr.wpa.key)
+       if (!msg.body.key_info.attr.wpa.key) {
+               kfree(msg.body.key_info.attr.wpa.seq);
                return -ENOMEM;
+       }
 
        if (rx_mic)
                memcpy(msg.body.key_info.attr.wpa.key + 16, rx_mic,
@@ -2897,10 +2899,13 @@ int wilc_add_rx_gtk(struct wilc_vif *vif, const u8 
*rx_gtk, u8 gtk_key_len,
        msg.body.key_info.attr.wpa.seq_len = key_rsc_len;
 
        result = wilc_enqueue_cmd(&msg);
-       if (result)
+       if (result) {
                netdev_err(vif->ndev, "RX GTK\n");
-       else
+               kfree(msg.body.key_info.attr.wpa.seq);
+               kfree(msg.body.key_info.attr.wpa.key);
+       } else {
                wait_for_completion(&hif_drv->comp_test_key_block);
+       }
 
        return result;
 }
-- 
2.7.4

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to