Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations

2016-07-21 Thread Julia Lawall
On Thu, 21 Jul 2016, SF Markus Elfring wrote: > >> @@ -323,14 +323,14 @@ static void tx_device_task(void *dev) > >> { > >>struct ks_wlan_private *priv = (struct ks_wlan_private *)dev; > >>struct tx_device_buffer *sp; > >> - int rc = 0; > >> > >>DPRINTK(4, "\n"); > >>if (cnt_txq

Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations

2016-07-21 Thread SF Markus Elfring
>> @@ -323,14 +323,14 @@ static void tx_device_task(void *dev) >> { >> struct ks_wlan_private *priv = (struct ks_wlan_private *)dev; >> struct tx_device_buffer *sp; >> -int rc = 0; >> >> DPRINTK(4, "\n"); >> if (cnt_txqbody(priv) > 0 >> && atomic_read(&priv->psstat

Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations

2016-07-20 Thread Wolfram Sang
On Sun, Jul 17, 2016 at 08:51:39PM +0200, Julia Lawall wrote: > > > On Sun, 17 Jul 2016, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Sun, 17 Jul 2016 19:40:47 +0200 > > > > Three variables will be set to an appropriate value a bit later. > > Thus omit the explicit initialisati

Re: [PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations

2016-07-17 Thread Julia Lawall
On Sun, 17 Jul 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 17 Jul 2016 19:40:47 +0200 > > Three variables will be set to an appropriate value a bit later. > Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring > --- > drivers/staging

[PATCH 9/9] staging: ks7010: Delete three unnecessary variable initialisations

2016-07-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Jul 2016 19:40:47 +0200 Three variables will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/staging/ks7010/ks7010_sdio.c | 8 1 file changed, 4 insertions(