Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

2020-12-14 Thread Sasha Levin
On Mon, Dec 14, 2020 at 08:06:25AM -0500, Konstantin Ryabitsev wrote: On Mon, Dec 14, 2020 at 02:07:11PM +0300, Dan Carpenter wrote: On Sat, Dec 12, 2020 at 07:09:01PM +0100, Andrea Parri wrote: > Hi Sasha, > > On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: > > From: "Andrea Parri

Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

2020-12-14 Thread Konstantin Ryabitsev
On Mon, Dec 14, 2020 at 02:07:11PM +0300, Dan Carpenter wrote: > On Sat, Dec 12, 2020 at 07:09:01PM +0100, Andrea Parri wrote: > > Hi Sasha, > > > > On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: > > > From: "Andrea Parri (Microsoft)" > > > > > > [ Upstream commit 3b8c72d076c42bf27

Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

2020-12-14 Thread Dan Carpenter
On Sat, Dec 12, 2020 at 07:09:01PM +0100, Andrea Parri wrote: > Hi Sasha, > > On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: > > From: "Andrea Parri (Microsoft)" > > > > [ Upstream commit 3b8c72d076c42bf27284cda7b2b2b522810686f8 ] > > FYI, we found that this commit introduced a re

Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

2020-12-13 Thread Sasha Levin
On Sat, Dec 12, 2020 at 07:09:01PM +0100, Andrea Parri wrote: Hi Sasha, On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: From: "Andrea Parri (Microsoft)" [ Upstream commit 3b8c72d076c42bf27284cda7b2b2b522810686f8 ] FYI, we found that this commit introduced a regression and poste

Re: [PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

2020-12-12 Thread Andrea Parri
Hi Sasha, On Sat, Dec 12, 2020 at 11:07:56AM -0500, Sasha Levin wrote: > From: "Andrea Parri (Microsoft)" > > [ Upstream commit 3b8c72d076c42bf27284cda7b2b2b522810686f8 ] FYI, we found that this commit introduced a regression and posted a revert: https://lkml.kernel.org/r/20201211131404.2135

[PATCH AUTOSEL 5.9 15/23] scsi: storvsc: Validate length of incoming packet in storvsc_on_channel_callback()

2020-12-12 Thread Sasha Levin
From: "Andrea Parri (Microsoft)" [ Upstream commit 3b8c72d076c42bf27284cda7b2b2b522810686f8 ] Check that the packet is of the expected size at least, don't copy data past the packet. Link: https://lore.kernel.org/r/20201118145348.109879-1-parri.and...@gmail.com Cc: "James E.J. Bottomley" Cc: "