On Sat, Aug 29, 2015 at 12:18:22AM -0500, Larry Finger wrote:
> Even though you are just moving code, I think you should fix the
> long line warnings from scripts/checkpatch, otherwise note that they
> are not fixed here, but they will be fixed in a later patch. As for
> the other warnings, they
On 09/15/2015 11:43 AM, Luca Ceresoli wrote:
Dear Larry,
Larry Finger wrote:
BTW, if a do a change not related to checkpatch warnings, say I remove
unneeded typecasts, and the change has impact on long lines which are
still long after the change, should I also wrap code to fit 80 chars _in
Dear Larry,
Larry Finger wrote:
On 09/14/2015 05:34 PM, Luca Ceresoli wrote:
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
On 09/14/2015 05:34 PM, Luca Ceresoli wrote:
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static,
and their declaration removed
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static,
and their declaration removed from rtw_mlme_ext.h, in a later commit.
This
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared static,
and their declaration removed from rtw_mlme_ext.h, in a later commit.
This would break compilation, since they are are referenced before their
definition.
Reorder these
Some of the report_*() functions are internal and will be declared static,
and their declaration removed from rtw_mlme_ext.h, in a later commit.
This would break compilation, since they are are referenced before their
definition.
Reorder these functions so that symbols are defined before they
