Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-28 Thread Wolfram Sang
Hi Tobin, > over this last month :). This is the reason for this email. Can I > please take you up on the offer of the SDW-823 card, if you can find > it? Sure, I have it here. Just mail me (privately) the address to send it to and I'll ship right away. > Secondly, I think I should spend some

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-26 Thread Tobin C. Harding
On Fri, Mar 31, 2017 at 12:42:22PM +0200, Wolfram Sang wrote: > Hi, > > > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > > a SDW-823 and should use the ks7010 driver. > > Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for > which no driver is

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-04 Thread Tobin C. Harding
On Tue, Apr 04, 2017 at 11:31:14PM +0200, Arend Van Spriel wrote: > >> On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > >>> "Tobin C. Harding" writes: > >>> > Except one: do you know off the top of your head of a canonical > implementation of a softmac wi-fi driver. >

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-04 Thread Arend Van Spriel
On 3-4-2017 23:39, Tobin C. Harding wrote: > On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote: >> seems we are missing out again? > > Sorry, I don't understand what this comment means? My bad. I had to reset my email account in thunderbird and now it needs to learn anew what is

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Tobin C. Harding
On Mon, Apr 03, 2017 at 12:15:15PM +0200, Arend Van Spriel wrote: > seems we are missing out again? Sorry, I don't understand what this comment means? > On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > > "Tobin C. Harding" writes: > > > >> Except one: do you know off the top

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Greg Kroah-Hartman
On Mon, Apr 03, 2017 at 07:03:59PM +1000, Tobin C. Harding wrote: > On Mon, Apr 03, 2017 at 08:19:40AM +0300, Kalle Valo wrote: > > + linux-wireless > > > > "Tobin C. Harding" writes: > > > > > On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: > > >> > > >> > The

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Arend Van Spriel
seems we are missing out again? On 3-4-2017 11:50, Toke Høiland-Jørgensen wrote: > "Tobin C. Harding" writes: > >> Except one: do you know off the top of your head of a canonical >> implementation of a softmac wi-fi driver. > > I'll suggest taking a look at the ath9k driver :)

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Toke Høiland-Jørgensen
"Tobin C. Harding" writes: > Except one: do you know off the top of your head of a canonical > implementation of a softmac wi-fi driver. I'll suggest taking a look at the ath9k driver :) -Toke ___ devel mailing list

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Kalle Valo
"Tobin C. Harding" writes: >> >> But if you want a clean WEXT driver first, this is a step in the right >> >> direction. >> > >> > Let's go for a CFG80211 driver and get out of staging :) So next step >> > is I guess study the ath6kl driver, learn how CFG80211 is done and >> >

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-03 Thread Tobin C. Harding
On Mon, Apr 03, 2017 at 08:19:40AM +0300, Kalle Valo wrote: > + linux-wireless > > "Tobin C. Harding" writes: > > > On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: > >> > >> > The code is untested, I have hardware in the mail. > >> > >> Cool! > > > > The card I

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-02 Thread Kalle Valo
+ linux-wireless "Tobin C. Harding" writes: > On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: >> >> > The code is untested, I have hardware in the mail. >> >> Cool! > > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > a SDW-823 and should

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-04-01 Thread Tobin C. Harding
On Fri, Mar 31, 2017 at 12:42:22PM +0200, Wolfram Sang wrote: > Hi, > > > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > > a SDW-823 and should use the ks7010 driver. > > Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for > which no driver is

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-03-31 Thread Wolfram Sang
Hi, > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is > a SDW-823 and should use the ks7010 driver. Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for which no driver is known: https://wikidevi.com/wiki/Spectec_SDW-821_%28MediaTek%29 For SDW-821 (SD

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-03-31 Thread Tobin C. Harding
On Fri, Mar 31, 2017 at 09:58:51AM +0200, Wolfram Sang wrote: > > > The code is untested, I have hardware in the mail. > > Cool! The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is a SDW-823 and should use the ks7010 driver. I am going to attempt to get it running on a

Re: [PATCH RFC] remove custom Michael MIC implementation

2017-03-31 Thread Wolfram Sang
> The code is untested, I have hardware in the mail. Cool! > If any one is interested and has any comments I would really like to > hear them. I am open to all suggestions (even down to trivial coding > style issues). I'll just repeat that the key move to get this driver out of staging is to

[PATCH RFC] remove custom Michael MIC implementation

2017-03-30 Thread Tobin C. Harding
This RFC can be applied on op on Linus' tree 89970a0 Configuration options needed to build are CONFIG_STAGING=y CONFIG_KS7010=m The ks7010 driver currently uses a custom implementation of the Michael MIC algorithm. The kernel has an implementation of this algorithm already. This patch is an