Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee wrote: > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: >> > >> > >> > On 2015년 11월 09일 18:05, punit vara wrote: >> >> >> >> On Mon, Nov

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Wed, Dec 02, 2015 at 08:39:10AM +0530, punit vara wrote: > On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee > wrote: > > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: > >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: > >> > > >>

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Wed, Dec 2, 2015 at 12:30 PM, Sudip Mukherjee wrote: > On Wed, Dec 02, 2015 at 08:39:10AM +0530, punit vara wrote: >> On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee >> wrote: >> > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Mon, Nov 09, 2015 at 08:09:36PM +0530, punit vara wrote: > On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee > wrote: > > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: > >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: > >> > > >>

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee wrote: > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: >> > >> > >> > On 2015년 11월 09일 18:05, punit vara wrote: >> >> >> >> On Mon, Nov

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On 2015년 11월 09일 17:18, Dan Carpenter wrote: On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote: Hi Punit Vara, I cannot find build errors on my build machines. According the log which you have posted before says *wilc is undeclared in the function init_wilc_driver, which means

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote: > On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: > > > > > > On 2015년 11월 09일 18:05, punit vara wrote: > >> > >> On Mon, Nov 9, 2015 at 2:25 PM, glen lee wrote: > >>> > >>> On 2015년 11월 09일

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote: > > > On 2015년 11월 09일 18:05, punit vara wrote: >> >> On Mon, Nov 9, 2015 at 2:25 PM, glen lee wrote: >>> >>> On 2015년 11월 09일 17:18, Dan Carpenter wrote: On Mon, Nov 09, 2015 at 05:02:48PM +0900,

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

Hi Punit Vara, I cannot find build errors on my build machines. According the log which you have posted before says *wilc is undeclared in the function init_wilc_driver, which means WILC_SPI is selected because one of SPI or SDIO should be chosen at the moment. Hence, struct wilc *wilc should

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote: > Hi Punit Vara, > > I cannot find build errors on my build machines. > > According the log which you have posted before says *wilc is undeclared in > the function init_wilc_driver, > which means WILC_SPI is selected because one of SPI

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Mon, Nov 9, 2015 at 1:48 PM, Dan Carpenter wrote: > On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote: >> Hi Punit Vara, >> >> I cannot find build errors on my build machines. >> >> According the log which you have posted before says *wilc is undeclared in >>

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On Mon, Nov 9, 2015 at 2:25 PM, glen lee wrote: > > On 2015년 11월 09일 17:18, Dan Carpenter wrote: >> >> On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote: >>> >>> Hi Punit Vara, >>> >>> I cannot find build errors on my build machines. >>> >>> According the log which you

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

On 2015년 11월 09일 18:05, punit vara wrote: On Mon, Nov 9, 2015 at 2:25 PM, glen lee wrote: On 2015년 11월 09일 17:18, Dan Carpenter wrote: On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote: Hi Punit Vara, I cannot find build errors on my build machines. According

[PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

This patch is to the linux_wlan.c file that fixes up break found during make drivers/staging/wilc1000/linux_wlan.o Patch add following things to file : -init_irq declaration -At preprocessor (!defined WILC_SDIO) to defination of init_irq -At preprocessor (!defined WILC_SDIO) to defination

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

Top posting beucase I am a bad person. Punit, you should have CC'd Glen since this is his code. The fix is still not right. It will cause an unused variable warning on some configs. To be honest, this code makes no sense. Why do we even have the wilc variable in this function when we never

Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

I just check the email, I will get back here after I check the patches related with this issue. regards, glen lee. On 2015년 11월 09일 06:59, Dan Carpenter wrote: Top posting beucase I am a bad person. Punit, you should have CC'd Glen since this is his code. The fix is still not right. It