Re: [PATCH V2] staging: wilc1000: drop explicit conversion to bool

2019-04-06 Thread Nicholas Mc Guire
On Sat, Apr 06, 2019 at 08:11:55PM +1100, Julian Calaby wrote: > Hi Nicholas, > > On Sat, Apr 6, 2019 at 7:48 PM Nicholas Mc Guire wrote: > > > > As the expression evaluates to a boolean anyway (relational and logical > > operators) conversion with the ternary operator is not needed here as > > c

Re: [PATCH V2] staging: wilc1000: drop explicit conversion to bool

2019-04-06 Thread Julian Calaby
Hi Nicholas, On Sat, Apr 6, 2019 at 7:48 PM Nicholas Mc Guire wrote: > > As the expression evaluates to a boolean anyway (relational and logical > operators) conversion with the ternary operator is not needed here as > coccinelle notes (boolconv.cocci) > > Signed-off-by: Nicholas Mc Guire > ---

[PATCH V2] staging: wilc1000: drop explicit conversion to bool

2019-04-06 Thread Nicholas Mc Guire
As the expression evaluates to a boolean anyway (relational and logical operators) conversion with the ternary operator is not needed here as coccinelle notes (boolconv.cocci) Signed-off-by: Nicholas Mc Guire --- V2: sent out the wrong version - the commit message was longer than 75 chars -