[RESEND PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-29 Thread Michael Zoran
The vchi_msg_queue function which is used by other drivers to queue a message is difficult to understand and overly generic. Remove it and replace it with two more specific functions. int vchi_queue_kernel_message(VCHI_SERVICE_HANDLE_T handle, void *data,

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Greg KH
On Thu, Jan 26, 2017 at 09:16:06AM +0300, Dan Carpenter wrote: > Please don't ever mention any legal issues on the list. We are not > lawyers and cannot help you. If you have legal concerns talk with your > lawyer or talk to Greg on the phone and he might be able to redirect you > to someone who

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Dan Carpenter
Please don't ever mention any legal issues on the list. We are not lawyers and cannot help you. If you have legal concerns talk with your lawyer or talk to Greg on the phone and he might be able to redirect you to someone who can help. regards, dan carpenter

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 12:27 -0800, Eric Anholt wrote: > Greg KH writes: > > > On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote: > > > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: > > > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > > > > > Just for clar

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 10:09 -0800, Michael Zoran wrote: > On Wed, 2017-01-25 at 18:39 +0100, Stefan Wahren wrote: > > > Michael Zoran hat am 25. Januar 2017 um > > > 17:53 > > > geschrieben: > > Looking at the TODO shows 3 candidates: vc_mem, bcm2835-camera, > > VCSM > > > > I suggest to pick one

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Eric Anholt
Greg KH writes: > On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote: >> On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: >> > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: >> > > Just for clarity, when you mean staging code? Are you talking about >> > > the >>

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 18:39 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 25. Januar 2017 um 17:53 > > geschrieben: > > > > > > On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote: > > > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > > > > Again, that's not my decision.  I

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Stefan Wahren
> Michael Zoran hat am 25. Januar 2017 um 17:53 > geschrieben: > > > On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote: > > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > > > Again, that's not my decision. I can go either way. But if the > > > > decision was made to delete i

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 08:53 -0800, Michael Zoran wrote: > On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote: > > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > > > Again, that's not my decision.  I can go either way.  But if > > > > the > > > > decision was made to delete it, I th

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote: > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > > Again, that's not my decision.  I can go either way.  But if the > > > decision was made to delete it, I think the 4.10 version should > > > also be > > > deleted because the same

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > Again, that's not my decision.  I can go either way.  But if the > > decision was made to delete it, I think the 4.10 version should > > also be > > deleted because the same logic applies.  Nothing uses it 4.10 > > either > > and 4.10 is s

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Dan Carpenter
On Wed, Jan 25, 2017 at 05:41:50AM -0800, Michael Zoran wrote: > > > I'm just saying that IF the decision was made to continue > > > upstreaming > > > these drivers, then I'm willing to continue helping by submitting > > > improvements. > > > > Either they should be merged, or these apis and struc

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 14:33 +0100, Greg KH wrote: > On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote: > > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: > > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > > > > Just for clarity, when you mean staging code? A

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Greg KH
On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote: > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > > > Just for clarity, when you mean staging code? Are you talking about > > > the > > > entire vc04_services

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > > Just for clarity, when you mean staging code? Are you talking about > > the > > entire vc04_services driver or are we talking about the > > vchi_msg_queue > > function?   > >

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Dan Carpenter
On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > Just for clarity, when you mean staging code? Are you talking about the > entire vc04_services driver or are we talking about the vchi_msg_queue > function? > > At this point, vc04_services isn't used by anything in the tree at all

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 15:10 +0300, Dan Carpenter wrote: > On Tue, Jan 24, 2017 at 12:34:04PM -0800, Michael Zoran wrote: > > The vchi_msg_queue function which is used by other drivers > > to queue a message is difficult to understand and overly > > generic. Remove it and replace it with two more sp

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Dan Carpenter
On Tue, Jan 24, 2017 at 12:34:04PM -0800, Michael Zoran wrote: > The vchi_msg_queue function which is used by other drivers > to queue a message is difficult to understand and overly > generic. Remove it and replace it with two more specific functions. The vc04_services is missing several drivers.

[PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-24 Thread Michael Zoran
The vchi_msg_queue function which is used by other drivers to queue a message is difficult to understand and overly generic. Remove it and replace it with two more specific functions. int vchi_queue_kernel_message(VCHI_SERVICE_HANDLE_T handle, void *data,