The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
From: Joshua Clayton <stillcompil...@gmail.com>
To: Larry Finger <larry.fin...@lwfinger.net>,
Florian Schilhabel <florian.c.schilha...@googlemail.com>,
Greg Kroah-Hartman <gre...@linuxfoundation.org>,
Sudip Mukherjee <sudipm.mukher...@gmail.com>,
Nitin Kuppelur <nitinkuppe...@gmail.com>,
Joshua Clayton <stillcompil...@gmail.com>,
Vaishali Thakkar <vthakkar1...@gmail.com>,
Tapasweni Pathak <tapaswenipat...@gmail.com>,
Daniel Baluta <daniel.bal...@intel.com>,
Melike Yurtoglu <aysemelikeyurto...@gmail.com>,
Max Perepelitsyn <mperepelit...@gmail.com>,
Aya Mahfouz <mahfouz.saif.elya...@gmail.com>,
Cristina Opriceana <cristina.oprice...@gmail.com>,
Dogukan Ergun <dogukan.er...@gmail.com>,
Julia Lawall <julia.law...@lip6.fr>,
Dan Carpenter <dan.carpen...@oracle.com>,
Haneen Mohammed <hamohammed...@gmail.com>,
Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
Cc: de...@driverdev.osuosl.org,
linux-ker...@vger.kernel.org
Subject: [PATCH V2 3/6] staging: rtl8712: fix comment
Date: Mon, 27 Jul 2015 07:31:51 -0700
Message-Id: <1438007514-9228-4-git-send-email-stillcompil...@gmail.com>
X-Mailer: git-send-email 2.4.6
In-Reply-To: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
References: <1438007514-9228-1-git-send-email-stillcompil...@gmail.com>
The old comment refers to a typedef name which is being removed,
and to a style of calculation which is no longer being used.
It falsely states that IELength is variable length, instead of IEs.
Change comment to simply state that the IEs field is a buffer of
variable size and that IELength refers to the current size.
Signed-off-by: Joshua Clayton <stillcompil...@gmail.com>
diff --git a/drivers/staging/rtl8712/wlan_bssdef.h
b/drivers/staging/rtl8712/wlan_bssdef.h
index 2ea8a3d..8c5d6e7 100644
--- a/drivers/staging/rtl8712/wlan_bssdef.h
+++ b/drivers/staging/rtl8712/wlan_bssdef.h
@@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs {
u16 Capabilities;
};
-/*
- * Length is the 4 bytes multiples of the sume of
- * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32)
- * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE)
- * + sizeof (struct NDIS_802_11_CONFIGURATION)
- * + sizeof (NDIS_802_11_RATES_EX) + IELength
-
- * Except the IELength, all other fields are fixed length. Therefore, we can
- * define a macro to present the partial sum.
- */
-
struct ndis_wlan_bssid_ex {
u32 Length;
unsigned char MacAddress[6];
@@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex {
struct NDIS_802_11_CONFIGURATION Configuration;
enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode;
NDIS_802_11_RATES_EX SupportedRates;
+ /* number of content bytes in EIs, which varies */
u32 IELength;
/*(timestamp, beacon interval, and capability information) */
u8 IEs[MAX_IE_SZ];
--
2.4.6
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
