Re: [PATCH V4 05/16] scsi: ipr: use sg helper to operate scatterlist

2019-06-17 Thread Ming Lei
On Mon, Jun 17, 2019 at 10:24:23AM +0200, Christoph Hellwig wrote: > > - for (i = 0; i < (len / bsize_elem); i++, buffer += bsize_elem) { > > - struct page *page = sg_page(&scatterlist[i]); > > + for (i = 0; i < (len / bsize_elem); i++, sg = sg_next(sg), buffer += > > bsize_elem) { >

Re: [PATCH V4 05/16] scsi: ipr: use sg helper to operate scatterlist

2019-06-17 Thread Christoph Hellwig
> - for (i = 0; i < (len / bsize_elem); i++, buffer += bsize_elem) { > - struct page *page = sg_page(&scatterlist[i]); > + for (i = 0; i < (len / bsize_elem); i++, sg = sg_next(sg), buffer += > bsize_elem) { Please split the overly long line. > + struct page *page

[PATCH V4 05/16] scsi: ipr: use sg helper to operate scatterlist

2019-06-16 Thread Ming Lei
Use the scatterlist iterators and remove direct indexing of the scatterlist array. This way allows us to pre-allocate one small scatterlist, which can be chained with one runtime allocated scatterlist if the pre-allocated one isn't enough for the whole request. Signed-off-by: Ming Lei --- drive