Re: [PATCH resend] staging: comedi: comedi_fops: coding style fixes

2016-09-12 Thread Ian Abbott
On 12/09/16 14:18, Matias Mucciolo wrote: From: Matias Mucciolo Those three lines are unnecessary, especially the initial blank line. I'm not sure whether Greg will ask you to fix it up. - Fixed coding style in comedi_fops.c Symbolic to octal permission.

Re: [PATCH resend] staging: comedi: comedi_fops: coding style fixes

2016-09-12 Thread Matias Mucciolo
Hi Ian yes its a coding style issue(checkpatch.pl WARN) and reference: https://lwn.net/Articles/696229/ (sorry about the noise.) -- Matias Mucciolo Area de Infraestructura. Piedras 737 C.A.B.A SUTEBA On Monday 12 September 2016 16:52:59 Ian Abbott wrote: > On 12/09/16 14:18, Matias

Re: [PATCH resend] staging: comedi: comedi_fops: coding style fixes

2016-09-12 Thread Ian Abbott
On 12/09/16 14:18, Matias Mucciolo wrote: From: Matias Mucciolo - Fixed coding style in comedi_fops.c Symbolic to octal permission. Signed-off-by: Matias Mucciolo --- drivers/staging/comedi/comedi_fops.c | 6 +++--- 1 file changed, 3

[PATCH resend] staging: comedi: comedi_fops: coding style fixes

2016-09-12 Thread Matias Mucciolo
From: Matias Mucciolo - Fixed coding style in comedi_fops.c Symbolic to octal permission. Signed-off-by: Matias Mucciolo --- drivers/staging/comedi/comedi_fops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git