Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-28 Thread Dmitry Osipenko
On 28.09.2017 10:23, Dan Carpenter wrote: > On Thu, Sep 28, 2017 at 02:28:04AM +0300, Dmitry Osipenko wrote: + if (is_baseline_profile) + frame->aux_paddr = 0xF4DEAD00; >>> >>> The handling of is_baseline_profile is strange to me. It feels like we >>> should always check it

Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-28 Thread Dan Carpenter
On Thu, Sep 28, 2017 at 02:28:04AM +0300, Dmitry Osipenko wrote: > >> + if (is_baseline_profile) > >> + frame->aux_paddr = 0xF4DEAD00; > > > > The handling of is_baseline_profile is strange to me. It feels like we > > should always check it before we use ->aux_paddr but we don't ever

Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-27 Thread Dmitry Osipenko
On 27.09.2017 12:45, Dan Carpenter wrote: >> --- /dev/null >> +++ b/drivers/staging/tegra-vde/Kconfig >> @@ -0,0 +1,6 @@ >> +config TEGRA_VDE >> +tristate "NVIDIA Tegra20 video decoder driver" >> +depends on ARCH_TEGRA_2x_SOC > > Could we get a || COMPILE_TEST here as well? > Good

Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-27 Thread Dmitry Osipenko
On 27.09.2017 12:45, Dan Carpenter wrote: > I feel like this code is good enough to go into the regular kernel > instead of staging, but I don't really know what "- properly handle > decoding faults" means in this context. As Greg pointed out, this patch should be cc'ed to media maintainers for a

Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-27 Thread Dan Carpenter
I feel like this code is good enough to go into the regular kernel instead of staging, but I don't really know what "- properly handle decoding faults" means in this context. Does the driver Oops all the time or what? Anyway, minor comments inline. On Tue, Sep 26, 2017 at 01:15:42AM +0300,

Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-26 Thread Dmitry Osipenko
On 26.09.2017 08:11, Stephen Warren wrote: > On 09/25/2017 05:45 PM, Dmitry Osipenko wrote: >> On 26.09.2017 02:01, Stephen Warren wrote: >>> On 09/25/2017 04:15 PM, Dmitry Osipenko wrote: Video decoder, found on NVIDIA Tegra20 SoC, supports a standard set of video formats like H.264 /

Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-25 Thread Stephen Warren
On 09/25/2017 05:45 PM, Dmitry Osipenko wrote: > On 26.09.2017 02:01, Stephen Warren wrote: >> On 09/25/2017 04:15 PM, Dmitry Osipenko wrote: >>> Video decoder, found on NVIDIA Tegra20 SoC, supports a standard set of >>> video formats like H.264 / MPEG-4 / WMV / VC1. Currently driver supports >>>

Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-25 Thread Dmitry Osipenko
On 26.09.2017 02:01, Stephen Warren wrote: > On 09/25/2017 04:15 PM, Dmitry Osipenko wrote: >> Video decoder, found on NVIDIA Tegra20 SoC, supports a standard set of >> video formats like H.264 / MPEG-4 / WMV / VC1. Currently driver supports >> decoding of CAVLC H.264 only. > > Note: I don't know

Re: [PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-25 Thread Stephen Warren
On 09/25/2017 04:15 PM, Dmitry Osipenko wrote: Video decoder, found on NVIDIA Tegra20 SoC, supports a standard set of video formats like H.264 / MPEG-4 / WMV / VC1. Currently driver supports decoding of CAVLC H.264 only. Note: I don't know anything much about video decoding on Tegra (just NV

[PATCH v1 1/2] staging: Introduce NVIDIA Tegra20 video decoder driver

2017-09-25 Thread Dmitry Osipenko
Video decoder, found on NVIDIA Tegra20 SoC, supports a standard set of video formats like H.264 / MPEG-4 / WMV / VC1. Currently driver supports decoding of CAVLC H.264 only. Signed-off-by: Dmitry Osipenko --- .../bindings/arm/tegra/nvidia,tegra20-vde.txt | 38 +