Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-12 Thread Benjamin Poirier
On 2020-10-12 19:51 +0800, Coiby Xu wrote: > On Sat, Oct 10, 2020 at 10:22:30PM +0900, Benjamin Poirier wrote: > > On 2020-10-10 18:02 +0800, Coiby Xu wrote: > > [...] > > > > > + do { \ > > > > > + err = fill_seg_(fmsg,

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-12 Thread Coiby Xu
On Sat, Oct 10, 2020 at 10:22:30PM +0900, Benjamin Poirier wrote: On 2020-10-10 18:02 +0800, Coiby Xu wrote: [...] > > + do { \ > > + err = fill_seg_(fmsg, >seg_hdr, dump->seg_regs); \ > > + if (err) {

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-10 Thread Benjamin Poirier
On 2020-10-10 18:02 +0800, Coiby Xu wrote: [...] > > > + do { \ > > > + err = fill_seg_(fmsg, >seg_hdr, dump->seg_regs); \ > > > + if (err) { \ > > > +

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-10 Thread Coiby Xu
On Sat, Oct 10, 2020 at 04:48:09PM +0900, Benjamin Poirier wrote: On 2020-10-08 19:58 +0800, Coiby Xu wrote: $ devlink health dump show DEVICE reporter coredump -p -j { "Core Registers": { "segment": 1, "values": [

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-10 Thread Benjamin Poirier
On 2020-10-08 19:58 +0800, Coiby Xu wrote: > $ devlink health dump show DEVICE reporter coredump -p -j > { > "Core Registers": { > "segment": 1, > "values": [ >

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-08 Thread Coiby Xu
On Thu, Oct 08, 2020 at 04:39:40PM +0300, Dan Carpenter wrote: On Thu, Oct 08, 2020 at 07:58:04PM +0800, Coiby Xu wrote: -static int -qlge_reporter_coredump(struct devlink_health_reporter *reporter, - struct devlink_fmsg *fmsg, void *priv_ctx, -

Re: [PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-08 Thread Dan Carpenter
On Thu, Oct 08, 2020 at 07:58:04PM +0800, Coiby Xu wrote: > -static int > -qlge_reporter_coredump(struct devlink_health_reporter *reporter, > - struct devlink_fmsg *fmsg, void *priv_ctx, > - struct netlink_ext_ack *extack) > +static int fill_seg_(struct

[PATCH v1 2/6] staging: qlge: coredump via devlink health reporter

2020-10-08 Thread Coiby Xu
$ devlink health dump show DEVICE reporter coredump -p -j { "Core Registers": { "segment": 1, "values": [