Re: [PATCH v2] Add tw5864 driver

2016-07-09 Thread Andrey Utkin
Hi Hans, Thanks for great help. I believe the issues highlighted by your are rectified by now. One chunk of your proposed changes seems to be wrong. Also I have one non-technical change I want to introduce to this driver, see it in the bottom of this letter ("Also, I decided to document known

Re: [PATCH v2] Add tw5864 driver

2016-07-01 Thread Hans Verkuil
On 06/10/2016 12:11 AM, Andrey Utkin wrote: > Fixed most of issues discovered by v1 and RFCv0 reviewers. Refactored a lot. > > The only thing from previous review I haven't got my head around yet is > framerate control - Hans Verkuil has told to support 1001/3 frame > interval, > but it's

Re: [PATCH v2] Add tw5864 driver

2016-06-12 Thread Andrey Utkin
Update: added local change - to require fewer DMA buffers; - to require fewer vb2_queue buffers; - don't require vb2_queue buffers to be DMA-capable. https://github.com/bluecherrydvr/linux/commit/410a86b08d230ff2a401ac9f5be3b30f8b29f30d ___ devel