Re: [PATCH v2] Staging: comedi: clean up conditional statement in addi_apci_3xxx.c

2014-02-14 Thread Ian Abbott
On 2014-02-14 01:02, Chase Southwood wrote: In this conditional statement, if (chan 16), but the instruction passed in data[0] is INSN_CONFIG_DIO_QUERY, the function does not return early, but the else-branch does not get executed either. As a result, mask would be used uninitialized in the

[PATCH v2] Staging: comedi: clean up conditional statement in addi_apci_3xxx.c

2014-02-13 Thread Chase Southwood
In this conditional statement, if (chan 16), but the instruction passed in data[0] is INSN_CONFIG_DIO_QUERY, the function does not return early, but the else-branch does not get executed either. As a result, mask would be used uninitialized in the next line. We want comedi_dio_insn_config() to