Re: [greybus-dev] [PATCH v2] Staging: greybus: Cleanup in greybus driver

On 04/17 :41, Alex Elder wrote: > On 4/16/19 5:13 PM, Madhumitha Prabakaran wrote: > > Fix a blank line after structure declarations. Also, convert > > macros into inline functions in order to maintain Linux kernel > > coding style based on which the inline function is > > preferable over the

Re: [PATCH v2] Staging: greybus: Cleanup in greybus driver

On 04/17 :25, Greg KH wrote: > On Tue, Apr 16, 2019 at 05:13:18PM -0500, Madhumitha Prabakaran wrote: > > Fix a blank line after structure declarations. Also, convert > > macros into inline functions in order to maintain Linux kernel > > coding style based on which the inline function is > >

Re: [greybus-dev] [PATCH v2] Staging: greybus: Cleanup in greybus driver

On 4/16/19 5:13 PM, Madhumitha Prabakaran wrote: > Fix a blank line after structure declarations. Also, convert > macros into inline functions in order to maintain Linux kernel > coding style based on which the inline function is > preferable over the macro. Madhumitha, here is my explanation for

Re: [greybus-dev] [PATCH v2] Staging: greybus: Cleanup in greybus driver

On Wed, Apr 17, 2019 at 06:19:50AM -0500, Alex Elder wrote: > I'm not completely sure about the inline function, but on the no blank > lines thing (and many other minor issues) "checkpatch.pl" is to blame. > There are lots of examples of issues that checkpatch points out that are > matters of

Re: [greybus-dev] [PATCH v2] Staging: greybus: Cleanup in greybus driver

On 4/17/19 1:25 AM, Greg KH wrote: > On Tue, Apr 16, 2019 at 05:13:18PM -0500, Madhumitha Prabakaran wrote: >> Fix a blank line after structure declarations. Also, convert >> macros into inline functions in order to maintain Linux kernel >> coding style based on which the inline function is >>

Re: [PATCH v2] Staging: greybus: Cleanup in greybus driver

On Tue, Apr 16, 2019 at 05:13:18PM -0500, Madhumitha Prabakaran wrote: > Fix a blank line after structure declarations. Also, convert > macros into inline functions in order to maintain Linux kernel > coding style based on which the inline function is > preferable over the macro. > > Blank line

Re: [greybus-dev] [PATCH v2] Staging: greybus: Cleanup in greybus driver

On 16-04-19, 17:13, Madhumitha Prabakaran wrote: > Fix a blank line after structure declarations. Also, convert > macros into inline functions in order to maintain Linux kernel > coding style based on which the inline function is > preferable over the macro. > > Blank line fixes are suggested by

[PATCH v2] Staging: greybus: Cleanup in greybus driver

Fix a blank line after structure declarations. Also, convert macros into inline functions in order to maintain Linux kernel coding style based on which the inline function is preferable over the macro. Blank line fixes are suggested by checkpatch.pl Signed-off-by: Madhumitha Prabakaran Changes