Re: [PATCH v2] Staging: rtlwifi: Remove unwanted parentheses

2019-04-04 Thread Madhumthia Prabakaran
On Thu, Apr 04, 2019 at 12:09:00PM +0300, Dan Carpenter wrote: > You should probably update the subject line because now it's not just > about parentheses any more. > > [PATCH v2] Staging: rtlwifi: clean up crc16_ccitt() > > So the one thing per patch rule is a little bit about selling your >

Re: [PATCH v2] Staging: rtlwifi: Remove unwanted parentheses

2019-04-04 Thread Dan Carpenter
You should probably update the subject line because now it's not just about parentheses any more. [PATCH v2] Staging: rtlwifi: clean up crc16_ccitt() So the one thing per patch rule is a little bit about selling your patch. We never allow "Clean up whole_file.c" but we do sometimes allow "Clean

[PATCH v2] Staging: rtlwifi: Remove unwanted parentheses

2019-04-03 Thread Madhumitha Prabakaran
Remove unwanted parentheses and use !! idiom in place of ternary operator to make code simple and more understandable. Signed-off-by: Madhumitha Prabakaran --- Changes in v2: - Changed commit log - Replaced ternary operator with !! idiom - Modified a BIT operator ---