Re: [PATCH v2] comedi/ni_pcidio: make all defines uppercase

2019-01-10 Thread Dan Carpenter
On Thu, Jan 10, 2019 at 12:05:41PM +0100, Marco Ammon wrote: > Hi, > > thank you for your feedback. > > On 18/12/18 12:18 Ian Abbott wrote: > > Minor quibble: There should be a description of the 'v2' changes here > > (after the '---' line). > > > > Also, the patch "Subject:" line is missing the

Re: [PATCH v2] comedi/ni_pcidio: make all defines uppercase

2019-01-10 Thread Greg Kroah-Hartman
On Thu, Jan 10, 2019 at 12:05:41PM +0100, Marco Ammon wrote: > Hi, > > thank you for your feedback. > > On 18/12/18 12:18 Ian Abbott wrote: > > Minor quibble: There should be a description of the 'v2' changes here > > (after the '---' line). > > > > Also, the patch "Subject:" line is missing the

Re: [PATCH v2] comedi/ni_pcidio: make all defines uppercase

2019-01-10 Thread Marco Ammon
Hi, thank you for your feedback. On 18/12/18 12:18 Ian Abbott wrote: > Minor quibble: There should be a description of the 'v2' changes here > (after the '---' line). > > Also, the patch "Subject:" line is missing the "staging:" tag.  The > usual set of tags for patches to this driver is

Re: [PATCH v2] comedi/ni_pcidio: make all defines uppercase

2018-12-18 Thread Ian Abbott
On 17/12/2018 20:51, Alexander Schroth wrote: According to the Linux coding guidelines, defines should be written in uppercase. This patch converts all define-statements in the ni_pcidio.c file to uppercase, thus matching the coding style of the kernel. Signed-off-by: Alexander Schroth

[PATCH v2] comedi/ni_pcidio: make all defines uppercase

2018-12-17 Thread Alexander Schroth
According to the Linux coding guidelines, defines should be written in uppercase. This patch converts all define-statements in the ni_pcidio.c file to uppercase, thus matching the coding style of the kernel. Signed-off-by: Alexander Schroth Signed-off-by: Marco Ammon ---