Re: [PATCH v2] kpc_i2c: Remove unused file

2019-05-13 Thread 'gre...@linuxfoundation.org'
On Thu, May 09, 2019 at 02:47:50PM +, Matt Sickler wrote: > >-Original Message- > >From: Dan Carpenter > > > >Add Staging: to the subject. > > Added to my notes so I don't forget it next time. > > >[PATCH v2] Staging: kpc_i2c: Remove unused file fileops.c > > > >On Thu, May 09, 2019

RE: [PATCH v2] kpc_i2c: Remove unused file

2019-05-09 Thread Matt Sickler
>-Original Message- >From: Dan Carpenter > >Add Staging: to the subject. Added to my notes so I don't forget it next time. >[PATCH v2] Staging: kpc_i2c: Remove unused file fileops.c > >On Thu, May 09, 2019 at 01:38:27PM +, Matt Sickler wrote: >> The whole file was wrapped in an #if 0

RE: [PATCH v2] kpc_i2c: Remove unused file

2019-05-09 Thread Matt Sickler
>-Original Message- >From: Dan Carpenter > >On Thu, May 09, 2019 at 02:47:50PM +, Matt Sickler wrote: > >A few people/subsystems (DRM) put the change log in the commit message >but that's pretty weird and I don't know if they do it on purpose or >they're just not aware how to do it prop

Re: [PATCH v2] kpc_i2c: Remove unused file

2019-05-09 Thread Dan Carpenter
On Thu, May 09, 2019 at 02:47:50PM +, Matt Sickler wrote: > >> --- > > ^^^ > > > >Here. > > Noted. I just looked up a "v2" patch in the mailing list > archive to see what that looks like. I'll try to do that > next time. > A few people/subsystems (DRM) put the change log in the commit mes

Re: [PATCH v2] kpc_i2c: Remove unused file

2019-05-09 Thread Dan Carpenter
Add Staging: to the subject. [PATCH v2] Staging: kpc_i2c: Remove unused file fileops.c On Thu, May 09, 2019 at 01:38:27PM +, Matt Sickler wrote: > The whole file was wrapped in an #if 0. I'm guessing it was a leftover file > from when we were first developing the driver and we just forgot ab

[PATCH v2] kpc_i2c: Remove unused file

2019-05-09 Thread Matt Sickler
The whole file was wrapped in an #if 0. I'm guessing it was a leftover file from when we were first developing the driver and we just forgot about it. V2: Forgot the signed-off-by line on the first patch. Signed-off-by: Matt Sickler --- drivers/staging/kpc2000/kpc_i2c/Makefile | 2 +- drive