Re: [PATCH v2] media: cedrus: Add support for VP8 decoding

2020-07-26 Thread Ezequiel Garcia
On Sun, 26 Jul 2020 at 16:16, Jernej Škrabec wrote: > > Hi Ezequiel! > > Dne sobota, 25. julij 2020 ob 15:08:37 CEST je Ezequiel Garcia napisal(a): > > Hi Jernej, > > > > As you know, I'm not familiar with this hardware, > > but I've tried to take a detailed look anyway. > > > > Thanks, any

Re: [PATCH v2] media: cedrus: Add support for VP8 decoding

2020-07-26 Thread Jernej Škrabec
Hi Ezequiel! Dne sobota, 25. julij 2020 ob 15:08:37 CEST je Ezequiel Garcia napisal(a): > Hi Jernej, > > As you know, I'm not familiar with this hardware, > but I've tried to take a detailed look anyway. > Thanks, any review is welcome. > The driver looks mostly good to me, I just have > some

Re: [PATCH v2] media: cedrus: Add support for VP8 decoding

2020-07-25 Thread Ezequiel Garcia
Hi Jernej, As you know, I'm not familiar with this hardware, but I've tried to take a detailed look anyway. The driver looks mostly good to me, I just have some minor comments. More importantly, seems the current uAPI control is supporting this platform nicely, which gives us some confidence to

[PATCH v2] media: cedrus: Add support for VP8 decoding

2020-07-22 Thread Jernej Skrabec
VP8 in Cedrus shares same engine as H264. Note that it seems necessary to call bitstream parsing functions, to parse frame header, otherwise decoded image is garbage. This is contrary to what is driver supposed to do. However, values are not really used, so this might be acceptable. It's possible