Re: [PATCH v2] staging: bcm2835-audio: Release resources on module_exit()

2018-03-21 Thread Kirill Marinushkin
On 03/21/18 16:03, Andy Shevchenko wrote: > On Thu, Mar 15, 2018 at 7:57 AM, Kirill Marinushkin > wrote: >> On 03/13/18 22:23, Andy Shevchenko wrote: >>> On Tue, Mar 13, 2018 at 9:34 PM, Kirill Marinushkin >>> wrote: In the current

Re: [PATCH v2] staging: bcm2835-audio: Release resources on module_exit()

2018-03-21 Thread Andy Shevchenko
On Thu, Mar 15, 2018 at 7:57 AM, Kirill Marinushkin wrote: > On 03/13/18 22:23, Andy Shevchenko wrote: >> On Tue, Mar 13, 2018 at 9:34 PM, Kirill Marinushkin >> wrote: >>> In the current implementation, `rmmod snd_bcm2835` does not release >>>

Re: [PATCH v2] staging: bcm2835-audio: Release resources on module_exit()

2018-03-14 Thread Kirill Marinushkin
On 03/13/18 22:23, Andy Shevchenko wrote: > On Tue, Mar 13, 2018 at 9:34 PM, Kirill Marinushkin > wrote: >> In the current implementation, `rmmod snd_bcm2835` does not release >> resources properly. It causes an oops when trying to list sound devices. >> >> This commit

Re: [PATCH v2] staging: bcm2835-audio: Release resources on module_exit()

2018-03-13 Thread Andy Shevchenko
On Tue, Mar 13, 2018 at 9:34 PM, Kirill Marinushkin wrote: > In the current implementation, `rmmod snd_bcm2835` does not release > resources properly. It causes an oops when trying to list sound devices. > > This commit fixes it. Nice catch! See my comments below. >

[PATCH v2] staging: bcm2835-audio: Release resources on module_exit()

2018-03-13 Thread Kirill Marinushkin
In the current implementation, `rmmod snd_bcm2835` does not release resources properly. It causes an oops when trying to list sound devices. This commit fixes it. The details WRT allocation / free are described below. Device structure WRT allocation: pdev \childdev[] \card \chip