Re: [PATCH v2] staging: ced401: fix double unlock bug

2014-02-24 Thread DaeSeok Youn
Ok. I will make a patch based on linux-next branch and send it again. Thanks. Daeseok Youn 2014-02-25 9:43 GMT+09:00 Greg KH : > On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote: >> >> After spin_lock() is called, all of if-else conditions in this brace >> should reach the end of els

Re: [PATCH v2] staging: ced401: fix double unlock bug

2014-02-24 Thread Greg KH
On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote: > > After spin_lock() is called, all of if-else conditions in this brace > should reach the end of else and spin_unlock() must be called. > So It doesn't need to call spin_unlock() without a return statement > for handling an error. >

Re: [PATCH v2] staging: ced401: fix double unlock bug

2014-02-24 Thread Dan Carpenter
On Mon, Feb 24, 2014 at 07:23:15PM +0900, Daeseok Youn wrote: > > After spin_lock() is called, all of if-else conditions in this brace > should reach the end of else and spin_unlock() must be called. > So It doesn't need to call spin_unlock() without a return statement > for handling an error. >

[PATCH v2] staging: ced401: fix double unlock bug

2014-02-24 Thread Daeseok Youn
After spin_lock() is called, all of if-else conditions in this brace should reach the end of else and spin_unlock() must be called. So It doesn't need to call spin_unlock() without a return statement for handling an error. Also sparse says: drivers/staging/ced1401/usb1401.c:1080:28: warning: con