Re: [PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread Gao Xiang
Hi Loic, On 2018/10/8 23:00, loïc tourlonias wrote: > Hi Gao, > On Mon, Oct 8, 2018 at 4:48 PM Gao Xiang wrote: >> >> Hi Greg, >> >> On 2018/10/8 22:43, Greg Kroah-Hartman wrote: >>> On Mon, Oct 08, 2018 at 10:36:39PM +0800, Gao Xiang wrote: Hi Greg, On 2018/10/8 22:22, Greg

Re: [PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread loïc tourlonias
Hi Gao, On Mon, Oct 8, 2018 at 4:48 PM Gao Xiang wrote: > > Hi Greg, > > On 2018/10/8 22:43, Greg Kroah-Hartman wrote: > > On Mon, Oct 08, 2018 at 10:36:39PM +0800, Gao Xiang wrote: > >> Hi Greg, > >> > >> On 2018/10/8 22:22, Greg Kroah-Hartman wrote: > >>> Why delete that line? > >>> > >>> But

Re: [PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread Gao Xiang
Hi Greg, On 2018/10/8 22:43, Greg Kroah-Hartman wrote: > On Mon, Oct 08, 2018 at 10:36:39PM +0800, Gao Xiang wrote: >> Hi Greg, >> >> On 2018/10/8 22:22, Greg Kroah-Hartman wrote: >>> Why delete that line? >>> >>> But wait, why do we even have this file at all? What's wrong with the >>> lib/lz4/

Re: [PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread Greg Kroah-Hartman
On Mon, Oct 08, 2018 at 10:36:39PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2018/10/8 22:22, Greg Kroah-Hartman wrote: > > Why delete that line? > > > > But wait, why do we even have this file at all? What's wrong with the > > lib/lz4/ code that we have in the kernel today? Shouldn't the code

Re: [PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread Gao Xiang
On 2018/10/8 22:36, Gao Xiang wrote: > Hi Greg, > > On 2018/10/8 22:22, Greg Kroah-Hartman wrote: >> Why delete that line? >> >> But wait, why do we even have this file at all? What's wrong with the >> lib/lz4/ code that we have in the kernel today? Shouldn't the code >> using these files be

Re: [PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread Gao Xiang
Hi Greg, On 2018/10/8 22:22, Greg Kroah-Hartman wrote: > Why delete that line? > > But wait, why do we even have this file at all? What's wrong with the > lib/lz4/ code that we have in the kernel today? Shouldn't the code > using these files be moved over to use the lib/ code instead and this

Re: [PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread Greg Kroah-Hartman
On Mon, Oct 08, 2018 at 04:14:09PM +0200, Loic Tourlonias wrote: > Add SPDX identifier to simplify header and remove whole license text > > v1 -> v2: > > Move SPDX identifier to first line and change comment delimiter The "changes" need to go below the --- line. > > Signed-off-by: Loic

[PATCH v2] staging: erofs: add SPDX identifer

2018-10-08 Thread Loic Tourlonias
Add SPDX identifier to simplify header and remove whole license text v1 -> v2: Move SPDX identifier to first line and change comment delimiter Signed-off-by: Loic Tourlonias --- drivers/staging/erofs/lz4defs.h | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-)