Re: [PATCH v2] staging: fbtft: fix out of bound access

2015-06-08 Thread Joe Perches
On Mon, 2015-06-08 at 20:22 +0530, Sudip Mukherjee wrote: On Thu, Jun 04, 2015 at 10:46:51PM -0700, Joe Perches wrote: On Fri, 2015-06-05 at 10:22 +0530, Sudip Mukherjee wrote: On Thu, Jun 04, 2015 at 01:48:31PM -0700, Joe Perches wrote: [] snip I looked at it a bit more and there's a

Re: [PATCH v2] staging: fbtft: fix out of bound access

2015-06-08 Thread Sudip Mukherjee
On Thu, Jun 04, 2015 at 10:46:51PM -0700, Joe Perches wrote: On Fri, 2015-06-05 at 10:22 +0530, Sudip Mukherjee wrote: On Thu, Jun 04, 2015 at 01:48:31PM -0700, Joe Perches wrote: [] snip I looked at it a bit more and there's a macro that calls write_register so there are actually many more

Re: [PATCH v2] staging: fbtft: fix out of bound access

2015-06-04 Thread Joe Perches
On Fri, 2015-06-05 at 10:22 +0530, Sudip Mukherjee wrote: On Thu, Jun 04, 2015 at 01:48:31PM -0700, Joe Perches wrote: [] ccing you just slipped out of my mind. No worries. diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c [] @@ -1067,8 +1067,6 @@

Re: [PATCH v2] staging: fbtft: fix out of bound access

2015-06-04 Thread Joe Perches
On Thu, 2015-06-04 at 19:04 +0530, Sudip Mukherjee wrote: str was 16 bytes but was mentioned as 128 in snprintf. again msg is 128 bytes but not sufficient to hold the complete debug message of register values. Now removed the use of str, msg and print the register values from the loop. []

[PATCH v2] staging: fbtft: fix out of bound access

2015-06-04 Thread Sudip Mukherjee
str was 16 bytes but was mentioned as 128 in snprintf. again msg is 128 bytes but not sufficient to hold the complete debug message of register values. Now removed the use of str, msg and print the register values from the loop. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- v2: