Hi Jack,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v5.5-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to
Hi Dan,
On 11/12/2019 6:58 PM, Dan Carpenter wrote:
This should just be sent to netdev. I spotted a couple bugs.
1) enable/disable we flipped xgmac_set_xgmii_2500_speed()
2) retries wasn't reset in a couple places.
I had a few tiny style nits as well but there is no reason to send it to
> > We are trying to upstream the datapath code for Intel new NoC gateway
> > (please refer to intel-gwdpa.txt at the end of the patch). It consists of
> > ethernet, WIFI and passive optics handling. Since the code is quite huge, we
> > have broken it into parts for internal review.
> >
> > As we
Yong ;
> > Shevchenko, Andriy ; net...@vger.kernel.org;
> > linux-ker...@vger.kernel.org; Amireddy Mallikarjuna reddy
> > ; da...@davemloft.net
> > Subject: Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit
> > Ethernet Switch (GSWIP) device driver
>
This should just be sent to netdev. I spotted a couple bugs.
1) enable/disable we flipped xgmac_set_xgmii_2500_speed()
2) retries wasn't reset in a couple places.
I had a few tiny style nits as well but there is no reason to send it to
staging.
regards,
dan carpenter
On Wed, Dec 11, 2019 at
On Wed, Dec 11, 2019 at 04:57:28PM +0800, Jack Ping CHNG wrote:
> - Added TODO (upstream plan)
Wait, your TODO file references things not even in this patch:
> ---
> drivers/staging/Kconfig| 2 +
> drivers/staging/Makefile | 1 +
>
On Wed, Dec 11, 2019 at 04:57:28PM +0800, Jack Ping CHNG wrote:
> This driver enables the Intel's LGM SoC GSWIP block.
> GSWIP is a core module tailored for L2/L3/L4+ data plane and QoS functions.
> It allows CPUs and other accelerators connected to the SoC datapath
> to enqueue and dequeue
