Re: [PATCH v2] staging: panel: Remove magic numbers in LCD commands

2014-12-06 Thread maf
On Sat, Dec 06, 2014 at 01:51:12PM +0530, Sudip Mukherjee wrote: > On Fri, Dec 05, 2014 at 10:28:19PM +0100, Mariusz Gorski wrote: > > Get rid of magic numbers in LCD commands and replace them with defined > > values, so that it's more obvious that the commands are doing. > > > > Signed-off-by: Ma

Re: [PATCH v2] staging: panel: Remove magic numbers in LCD commands

2014-12-06 Thread Sudip Mukherjee
On Fri, Dec 05, 2014 at 10:28:19PM +0100, Mariusz Gorski wrote: > Get rid of magic numbers in LCD commands and replace them with defined > values, so that it's more obvious that the commands are doing. > > Signed-off-by: Mariusz Gorski > --- > v2: Found and got rid of two more magic number usages

[PATCH v2] staging: panel: Remove magic numbers in LCD commands

2014-12-05 Thread Mariusz Gorski
Get rid of magic numbers in LCD commands and replace them with defined values, so that it's more obvious that the commands are doing. Signed-off-by: Mariusz Gorski --- v2: Found and got rid of two more magic number usages drivers/staging/panel/panel.c | 96 +-